Test for Null statusChanges field in Job status #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hema (#346) * Add currentStreams DTO * add cluster name into endpoints response
* Add repair job version which follows notifications * Add new getStatusChanges and message * Fix formatting * Add tests for the async endpoint in v1 also * Change setStatusChange * Fix test indentation * Rename RpcParam * Fix rebase * Add back the payload in the IT test to the request * Update openapi.json, make special case for return id 0 to the Rpc call - should fix the test also which can not be run otherwise on single node cluster * Disable the test, throw exception if Cassandra refuses to repair * Fix repair test to run repair for a keyspace with RF 2 (#351) * Update openapi.json after rebase --------- Co-authored-by: Erik Merkle <[email protected]>
* Allow `repair()` RPC method to take more arguments (as required by Reaper). Get the old NodeOpsResources class calling the new RPC method signature. --------- Co-authored-by: Erik Merkle <[email protected]> * Cancel repairs endpoint (#368) * Add cancelAllRepairs endpoint and requisite NodeOps.
…h BigIntegers being represented in open API spec as ints. (#370)
|
No linked issues found. Please add the corresponding issues in the pull request description. |
Miles-Garnsey
force-pushed
the
bugfix/null-statuschanges
branch
2 times, most recently
from
64d8cc8 to
b51d29f
Compare
…client for build reasons.
Miles-Garnsey
force-pushed
the
bugfix/null-statuschanges
branch
4 times, most recently
from
d802523 to
13d2017
Compare
…client for build reasons.
Miles-Garnsey
force-pushed
the
bugfix/null-statuschanges
branch
from
13d2017 to
0613d1c
Compare
Miles-Garnsey
changed the title
|
On hold pending the ability to test the client library from inside this repo. #389 |
emerkle826
force-pushed
the
feature/client-gen
branch
from
ba69e9f to
25957a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From Reaper, we sometimes observe that the statusChanges field implemented as part of this PR can be null. This results in no repair progress notifications being passed to Reaper.
This PR creates an integration test to detect the problem. The actual fix is over here.
Fixes
#386